Skip to content

feat(theme): follow the system colour scheme on the first visit #185

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2026
Merged

feat(theme): follow the system colour scheme on the first visit #185

merged 2 commits into from
Nov 10, 2026
+22 −4

Conversation

ronjalh
Copy link
Member

@ronjalh ronjalh commented Nov 7, 2026

Summary

  • On the first visit, when nothing is stored under theme, the theme starts from prefers-color-scheme. A stored choice always wins.
  • Later changes of the system setting are not followed: the theme is stored on first render, as before (the open question in the issue).
  • Test covers both cases: nothing stored with a dark system, and a stored choice that differs from the system.

Closes #168

🤖 Generated with Claude Code

@ronjalh ronjalh requested a review from a team as a code owner November 7, 2026 15:38
@ronjalh ronjalh self-assigned this Nov 7, 2026
@anettkva
Copy link
Member

Looks good and does what it says! tsc, lint, Prettier, the build and all 313 frontend tests pass.

One optional thing: vi.unstubAllGlobals() runs at the end of the test, so if an expectation fails first, the fake matchMedia stays for the next tests. An afterEach would always clean it up. Do you want to change that before we merge, or should we merge it as it is?

Generated with Claude Code, from my review.

@xeniag xeniag merged commit 255b435 into dev Nov 10, 2026
@xeniag xeniag deleted the 168-follow-the-os-colour-scheme branch November 10, 2026 19:38
Sign in to join this conversation on GitHub.
Reviewers

@IT2810-H26/it2810-h26-t29 IT2810-H26-T29 Awaiting requested review from IT2810-H26/it2810-h26-t29 IT2810-H26/it2810-h26-t29 is a code owner

Assignees

@ronjalh ronjalh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronjalh @anettkva @xeniag